net: mqtt: Remove misleading comment #96863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukkar
approved these changes
Oct 2, 2025
|
@kevinior could you rebase the PR against latest main and force push, there is unrelated CI failure that is probably fixed by rebase. |
pdgendt
approved these changes
Oct 2, 2025
Setting the peer hostname to NULL does not skip hostname verification. After discussion in the issue it was agreed that it's better to remove this comment than to implement skipping hostname verification. Also fixed a typo in the remaining part of the comment. Fixes: zephyrproject-rtos#96853 Signed-off-by: Kevin ORourke <kevin.orourke@ferroamp.se>
kevinior
force-pushed
the
96853_remove_misleading_comment
branch
from
7ead272 to
0c6ef1b
Compare
Done, I'm hoping it gets through CI this time. |
|
rlubos
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the peer hostname to NULL does not skip hostname verification. After discussion in the issue it was agreed that it's better to remove this comment than to implement skipping hostname verification.
Also fixed a typo in the remaining part of the comment.
Fixes: #96853