Wraping calls to find_package #389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping calls to
find_package
allows building cppzmq without doingfind_package(ZeroMQ)
if the libzmq target is already defined.This occurs when building a project which vendors all of its dependencies with
add_subdirectory
, resulting in targets being defined and find_package to fail.Note: I agree that vendoring dependencies in generally bad practice but this is a requirement in our context as we are building a PyPI wheel.