Skip to content

Conversation

SylvainCorlay
Copy link
Contributor

Wrapping calls to find_package allows building cppzmq without doing find_package(ZeroMQ) if the libzmq target is already defined.

This occurs when building a project which vendors all of its dependencies with add_subdirectory, resulting in targets being defined and find_package to fail.

Note: I agree that vendoring dependencies in generally bad practice but this is a requirement in our context as we are building a PyPI wheel.

@coveralls
Copy link

coveralls commented Mar 5, 2020

Pull Request Test Coverage Report for Build 345

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.483%

Totals Coverage Status
Change from base Build 335: 0.0%
Covered Lines: 691
Relevant Lines: 799

💛 - Coveralls

@sigiesec
Copy link
Member

sigiesec commented Mar 7, 2020

Looks ok to me. I wonder if there is a generic solution for this in CMake? I guess this may be necessary for any library in such circumstances.

@sigiesec sigiesec merged commit c7766c0 into zeromq:master Mar 7, 2020
@SylvainCorlay SylvainCorlay deleted the wrap-find-package-zeromq branch March 7, 2020 14:07
@SylvainCorlay
Copy link
Contributor Author

I wonder if there is a generic solution for this in CMake?

Not to my knowledge. I have looked and found this pattern in a bunch of places...

@SylvainCorlay
Copy link
Contributor Author

Hey, is there a plan for a release soon that would include that change? I see that the master branch already indicates 4.7.

@SylvainCorlay
Copy link
Contributor Author

@sigiesec do you guys have plans for a release including these changes in the near future?

Also, I wanted to say kudos to the whole team working on cppzmq. Clear deprecation warnings, clean cmake... The project has come a long way in the past year.

@SylvainCorlay SylvainCorlay mentioned this pull request Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants