Race condition with received message causes ZMQ_CONNECT_RID to be assigned to wrong socket #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears the test that is failing (TermEndpointIpcTest) has been intermittently failing on the master branch, so I believe that is flaky test and unrelated to my commit. |
|
You're right, it has been sporadically failing for some time now, I will propose a PR about that. Thanks for the race condition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a race condition between receiving connections on the io thread and the call to socket.connect(), ZMQ_CONNECT_RID can be assigned to the wrong peer socket.
I recently fixed the same bug in the libzmq implementation. You can see more details there.