Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreliable test cases about resolving supposedly invalid addresses #706

Conversation

daveyarwood
Copy link
Contributor

As I noted in #704 (comment), these tests are failing on my machine, as presumably my ISP provides a fallback IP when resolving nonexistent addresses.

Since we can't rely on the address resolution available in the environment used to run the tests, I don't think we can really test the "sad path" of attempting to resolve a supposedly invalid address. So, we should just remove these tests, at least for now, to unblock releasing JeroMQ 0.5.1. (see #704)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 84.805% when pulling fb3c1f9 on daveyarwood:remove-sad-path-address-resolution-tests into 170885a on zeromq:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 84.805% when pulling fb3c1f9 on daveyarwood:remove-sad-path-address-resolution-tests into 170885a on zeromq:master.

@trevorbernard trevorbernard merged commit 46b2042 into zeromq:master Apr 3, 2019
@daveyarwood daveyarwood deleted the remove-sad-path-address-resolution-tests branch April 3, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants