strip down __init__.py so importing pyczmq is much faster #19
Conversation
The basic "import pyczmq" goes from ~1.2 sec to 0.03 sec. Of course that's not very realistic, since no one wants just the empty package. A more realistic example: "from pyczmq import zmq" is now 0.36 sec (from 1.2 sec). And "from pyczmq import zmq, zctx, zsocket" is now 0.53 sec. This is also more in keeping with generally accepted practice in the Python community (at least as I read things). The catch is that this can break existing imports. Specifically, any code like this: import pyczmq ctx = pyczmq.zctx.new() socket = pyczmq.zsocket.new(...) WILL BREAK. The single import will have to be replaced by import pyczmq.zctx import pyczmq.zsocket (or "from pyczmq import zctx, zsocket" if you don't mind changing your code too).
|
I'm ok with this change but I'd like to hear from @claws and @mhaberler to make sure it's ok with them. Also it looks like the Travis CI tests are breaking on this branch, do they pass for @gward? |
|
fine with me - go ahead I did notice the somewhat lengthy startup but didnt bother. Hey, it could be worse - just think of firing off a Java app ;) |
|
I am fine with the change so long as the tests still pass. The Travis builds appeared to be breaking for unrelated reasons (czmq test,
|
strip down __init__.py so importing pyczmq is much faster
No description provided.