Windows prebuilts #44
Conversation
|
Woo! |
|
Looks like I broke the linux build |
| 'libraries': [ '<(PRODUCT_DIR)/../../zmq/lib/libzmq.a' ], | ||
| }], | ||
| ] | ||
| } |
There was a problem hiding this comment.
Wow you really went to town here. 👀
binding.gyp
Outdated
| }], | ||
| ['OS=="linux"', { | ||
| 'libraries': [ '<(PRODUCT_DIR)/../../zmq/lib/libzmq.a' ], | ||
| 'libraries': [ '<(PRODUCT_DIR)/../../zmq/lib/libzmq.a' ], |
There was a problem hiding this comment.
This looks like a duplicate that needs to be deleted.
Either that or you meant to bring in the include_dirs that you introduced in OS X + Solaris.
| #define ZMQ_VERSION_MINOR 0 | ||
| #define ZMQ_VERSION_PATCH 4 | ||
| #define ZMQ_VERSION_MINOR 1 | ||
| #define ZMQ_VERSION_PATCH 5 |
There was a problem hiding this comment.
These are the headers from the official release
| #endif | ||
|
|
||
| #endif | ||
| /* This file is deprecated, and all its functionality provided by zmq.h */ |
|
CI is happy 💚 |
binding.gyp
Outdated
| 'conditions': [ | ||
| ['OS=="win"', { | ||
| 'win_delay_load_hook': 'true', | ||
| 'msbuild_toolset': 'v120', |
There was a problem hiding this comment.
Before you merge. I'll try to remove this line to see what appveyor does.
There was a problem hiding this comment.
good thing the github ui is responsive because I was about to merge this now!
There was a problem hiding this comment.
I'll add it again. Looks like it's necessary.
|
Everything good to go 🚀 📦 |
|
Cool, let's |
.
|
Great I'll push a tag. |
I added a static compiled version of zmq
v4.1.5. It is linked (statically) in the.gypfile. I went ahead and also removed the DLL stuff inside thebindings.ccfile.The prebuilts will have a size of approx. 230 kB.
So this time I'm quite confident that the'll work though I didn't know how to test this without a release.