Remove default values from method signatures #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glensc
changed the title
|
I would have personally just filled defaults to the rest of the arguments as |
falkenhawk
reviewed
Mar 15, 2021
There was a problem hiding this comment.
Looking at the code, the rest of arguments are required and they can't be null for the components to work properly.
Since values of $genNum and $queueName are validated anyway, I'd just remove the defaults and not change any logic inside method bodies. Would that be okay with you?
I suspect the default values on those arguments could be just unintended leftovers. 🤷♂️
packages/zend-service-windowsazure/library/Zend/Service/WindowsAzure/Storage/Queue.php
Outdated
Show resolved
Hide resolved
@falkenhawk you requested changes, I have not reviewed these, so marked back as Draft. |
As optional before required params is forbidden in PHP 8.0 these signatures needed to be changed and the functionality of the method adapted accordingly to still retain the original behaviour. Signed-off-by: Alexander Wozniak <wozniak@oktopos.com> Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
|
Rebased and applied proposed fixes. Removed Draft |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As optional before required params are forbidden in PHP 8.0 these signatures
needed to be changed and the functionality of the method adapted
accordingly to still retain the original behavior.
Moved out of #67,
which was moved out from #32