Expose proof and historical access methods to VersionedKvStore Python API #101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive enhancement of the VersionedKvStore Python API to expose cryptographic proof functionality and historical access methods that were previously only available in Rust.
This PR addresses missing critical functionality in the Python
VersionedKvStore
class by exposing proof generation/verification and historical state access methods.Changes Made
1. Proof Methods
Rust Implementation (
src/git/versioned_store.rs
)generate_proof(&self, key: &[u8]) -> Proof<N>
methodverify(&self, proof: Proof<N>, key: &[u8], expected_value: Option<&[u8]>) -> bool
methodtest_versioned_store_proof_methods
Python Bindings (
src/python.rs
)generate_proof(key: bytes) -> bytes
to PyVersionedKvStoreverify_proof(proof_bytes: bytes, key: bytes, expected_value: Optional[bytes]) -> bool
2. Historical Access Method
Python Bindings (
src/python.rs
)get_keys_at_ref(reference: str) -> List[Tuple[bytes, bytes]]
methodTesting
test_get_keys_at_ref
3. Type Stubs (
python/prollytree/prollytree.pyi
)generate_proof
andverify_proof
method signaturesget_keys_at_ref
method signature with comprehensive documentationMergeConflict
andConflictResolution
classesget_commits_for_key
,get_commit_history
,merge
, andtry_merge
methods4. Documentation
API Usage Examples
Cryptographic Proofs
Historical Access
Benefits
Test Plan
test_versioned_store_proof_methods
verifies proof functionalitytest_get_keys_at_ref
verifies historical accesscargo fmt
,cargo clippy
)Checklist
🤖 Generated with Claude Code