Add comprehensive type stubs for VersionedKvStore proof and merge functionality #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose cryptographic proof functionality from ProllyTree to VersionedKvStore
in both Rust and Python APIs for consistent proof generation and verification
across versioned key-value operations.
## Changes
### Rust Implementation
- Add `generate_proof(&self, key: &[u8]) -> Proof<N>` to VersionedKvStore
- Add `verify(&self, proof: Proof<N>, key: &[u8], expected_value: Option<&[u8]>) -> bool`
- Both methods delegate to underlying ProllyTree implementation
- Add comprehensive unit test `test_versioned_store_proof_methods`
### Python Bindings
- Add `generate_proof(key: bytes) -> bytes` to PyVersionedKvStore
- Add `verify_proof(proof_bytes: bytes, key: bytes, expected_value: Optional[bytes]) -> bool`
- Handle proof serialization/deserialization with bincode
- Thread-safe implementation with proper GIL handling
## API Usage
```python
store = VersionedKvStore.open("/path/to/repo")
proof = store.generate_proof(b"key1")
is_valid = store.verify_proof(proof, b"key1", b"value1")
```
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
Add documentation for the newly added generate_proof and verify_proof methods in the VersionedKvStore example section. Also update the cryptographic verification feature description to clarify it's available for both trees and versioned storage. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…ctionality Update Python type stubs (.pyi) to include the newly added proof methods and previously missing merge functionality for better IDE support and type checking. ## Added Type Stubs ### VersionedKvStore Methods - `generate_proof(key: bytes) -> bytes` - Generate cryptographic proofs - `verify_proof(proof: bytes, key: bytes, expected_value: Optional[bytes]) -> bool` - Verify proofs - `get_commits_for_key(key: bytes) -> List[Dict[str, Union[str, int]]]` - Get key history - `get_commit_history() -> List[Dict[str, Union[str, int]]]` - Get repository history - `merge(source_branch: str, conflict_resolution: Optional[ConflictResolution]) -> str` - Merge branches - `try_merge(source_branch: str) -> Tuple[bool, List[MergeConflict]]` - Attempt merge with conflict detection ### New Classes - `MergeConflict` - Represents merge conflicts with key, base_value, source_value, destination_value properties - `ConflictResolution` - Enum with IgnoreAll, TakeSource, TakeDestination strategies These additions ensure comprehensive IDE support and type checking for all VersionedKvStore functionality including the newly added proof methods. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.