Skip to content

Consolidate VersionedKvStore commits to eliminate duplicate metadata commits #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 73 commits into from
Jul 23, 2025
Merged

Consolidate VersionedKvStore commits to eliminate duplicate metadata commits #68

merged 73 commits into from
Jul 23, 2025

Conversation

zhangfengcdt
Copy link
Owner

@zhangfengcdt zhangfengcdt commented Jul 23, 2025 •
edited
Loading

This PR addresses the issue where VersionedKvStore::commit() was creating two separate git commits: one for the main data changes and another for prolly metadata files (prolly_config_tree_config and prolly_hash_mappings). The changes consolidate these into a single atomic commit.

Changes Made

Core Changes

  • Modified VersionedKvStore::commit() (src/git/versioned_store.rs:257-291)
    • Updated create_git_tree() to stage prolly metadata files before creating the git tree using git add and git
      write-tree
    • Removed the separate commit_prolly_metadata() call that was creating the second commit
    • Maintains the same functionality while reducing commit count from 2 to 1
  • Updated VersionedKvStore::init() (src/git/versioned_store.rs:104-114)
    • Removed the extra metadata commit after initialization
    • Now creates only the initial commit which includes metadata files
  • Removed unused function (src/git/versioned_store.rs)
    • Deleted commit_prolly_metadata() function as it's no longer needed
    • Function was only used for creating separate metadata commits

@zhangfengcdt
Fix the history command for finance advisor example
1c9bbac
@zhangfengcdt
fix history serde issue
20de49d
@zhangfengcdt
fix history commit issue
c62393d
@zhangfengcdt
fix commit_prolly_metadata
d30bde5
@zhangfengcdt
add readme file for finance advisor example
e4c7fed
@zhangfengcdt
fix the memory command
ca2a571
@zhangfengcdt
fix clippy issue
2ee99fc
@zhangfengcdt
Initial commit
84e54dd
@zhangfengcdt
Update prolly metadata after commit: Initial commit
e04ca81
@zhangfengcdt
Create table: market_data
0c06678
@zhangfengcdt
Update prolly metadata after commit: Create table: market_data
d092898
@zhangfengcdt
Create table: recommendations
baa3fc7
@zhangfengcdt
Update prolly metadata after commit: Create table: recommendations
6b34359
@zhangfengcdt
Create table: audit_log
3bb2722
@zhangfengcdt
Update prolly metadata after commit: Create table: audit_log
734b9b1
@zhangfengcdt
Create table: cross_references
5f1418a
@zhangfengcdt
Update prolly metadata after commit: Create table: cross_references
03f22a6
@zhangfengcdt
Create table: client_profiles
67bdb55
@zhangfengcdt
Update prolly metadata after commit: Create table: client_profiles
33f110c
@zhangfengcdt
Initial commit
5b0f444
@zhangfengcdt
Update prolly metadata after commit: Initial commit
b345a81
@zhangfengcdt
Create table: market_data
415612e
@zhangfengcdt
Update prolly metadata after commit: Create table: market_data
6055f9d
@zhangfengcdt
Create table: recommendations
adceba9
@zhangfengcdt
Update prolly metadata after commit: Create table: recommendations
81e6a30
@zhangfengcdt
Create table: audit_log
40511f1
@zhangfengcdt
Update prolly metadata after commit: Create table: audit_log
a78be5d
@zhangfengcdt
Create table: cross_references
91cabd7
@zhangfengcdt
Update prolly metadata after commit: Create table: cross_references
8472ead
@zhangfengcdt
Create table: client_profiles
ca5d690
zhangfengcdt and others added 19 commits July 22, 2025 15:54
@zhangfengcdt
Update prolly metadata after commit: Create table: audit_log
bc5ec5e
@zhangfengcdt
Create table: cross_references
6e65805
@zhangfengcdt
Update prolly metadata after commit: Create table: cross_references
981e92f
@zhangfengcdt
Create table: client_profiles
21e69d9
@zhangfengcdt
Update prolly metadata after commit: Create table: client_profiles
30d59d7
@zhangfengcdt
Initial commit
31f89a7
@zhangfengcdt
Update prolly metadata after commit: Initial commit
35931db
@zhangfengcdt
Create table: market_data
be8cde4
@zhangfengcdt
Update prolly metadata after commit: Create table: market_data
c2e1363
@zhangfengcdt
Create table: recommendations
be97df6
@zhangfengcdt
Update prolly metadata after commit: Create table: recommendations
8a726af
@zhangfengcdt
Create table: audit_log
7ea4f45
@zhangfengcdt
Update prolly metadata after commit: Create table: audit_log
ebcbdff
@zhangfengcdt
Create table: cross_references
051815e
@zhangfengcdt
Update prolly metadata after commit: Create table: cross_references
2e7b3b5
@zhangfengcdt
Create table: client_profiles
8c1e2ad
@zhangfengcdt
Update prolly metadata after commit: Create table: client_profiles
5b5693c
@zhangfengcdt
fix recommend engine
166747e
@zhangfengcdt
combine data and meta commit
afc16f6
@zhangfengcdt zhangfengcdt marked this pull request as draft July 23, 2025 04:24
@zhangfengcdt zhangfengcdt marked this pull request as ready for review July 23, 2025 04:24
@zhangfengcdt zhangfengcdt force-pushed the feature/ai.agent.financial_advisor7 branch from 6cd9feb to a9fbd97 Compare July 23, 2025 04:39
@zhangfengcdt zhangfengcdt requested a review from Copilot July 23, 2025 13:58
@zhangfengcdt zhangfengcdt changed the title Fix the history command for finance advisor example Consolidate VersionedKvStore commits to eliminate duplicate metadata commits Jul 23, 2025
@zhangfengcdt zhangfengcdt merged commit fb7d810 into main Jul 23, 2025
2 checks passed
@zhangfengcdt zhangfengcdt deleted the feature/ai.agent.financial_advisor7 branch July 29, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhangfengcdt