Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(): fix cover style #259

Closed
wants to merge 1 commit into from
Closed

style(): fix cover style #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/griffith/src/components/Player.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ export default StyleSheet.create({
top: 0,
bottom: 0,
overflow: 'hidden',
backgroundColor: '#000',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这可能会和 cover prop 使用冲突。
可以加个条件，如果没传 cover 就没有背景色。（或者直接用现有的 hideCover prop 达到需要）。

cursor: 'pointer',
visibility: 'hidden',
opacity: 0,
Expand Down