Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anchor / target assignment visualization notebook #116

Merged
merged 6 commits into from
Jul 1, 2021

Conversation

zhiqwang
Copy link
Owner

@zhiqwang zhiqwang commented Jun 14, 2021

Fixing #60

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@zhiqwang zhiqwang mentioned this pull request Jun 14, 2021
9 tasks
@zhiqwang zhiqwang added the enhancement New feature or request label Jun 14, 2021
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #116 (855fb59) into master (dbc1c72) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 855fb59 differs from pull request most recent head db58f63. Consider uploading reports for the commit db58f63 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   83.56%   83.54%   -0.03%     
==========================================
  Files           8        8              
  Lines         779      784       +5     
==========================================
+ Hits          651      655       +4     
- Misses        128      129       +1     
Flag Coverage Δ
unittests 83.54% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_data_pipeline.py 100.00% <0.00%> (ø)
test/common_utils.py 53.38% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc1c72...db58f63. Read the comment docs.

@zhiqwang zhiqwang force-pushed the anchor-visualization branch 3 times, most recently from 5be0461 to 3388991 Compare June 17, 2021 02:09
@zhiqwang zhiqwang changed the title Add anchor assignment visualization Add anchor / target assignment visualization notebook Jul 1, 2021
@zhiqwang zhiqwang added the documentation Improvements or additions to documentation label Jul 1, 2021
@zhiqwang zhiqwang merged commit 82d6afb into master Jul 1, 2021
@zhiqwang zhiqwang deleted the anchor-visualization branch July 1, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant