Skip to content

Conversation

kcbanner
Copy link
Contributor

@kcbanner kcbanner commented Jul 20, 2025

Supersedes #5.

As of 0.15.x usingnamespace has been removed: ziglang/zig#20663

Changes:

  • Remove usingnamespace usage
  • Fixup build script / callconv deprecations
  • Use the new @extern field, .is_dll_import, to allow linking the memory allocation functions from a shared library when using the -msvc ABI
  • Alignment fixup
  • Change appendMeshPrimitive to use unmanaged data structures (managed versions are being deprecated)

kcbanner added 3 commits July 20, 2025 02:24
…ion functions from a shared library with the -msvc ABI
- Fixup build script / callconv deprecations
Copilot

This comment was marked as outdated.

@hazeycode hazeycode requested a review from Copilot August 28, 2025 23:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the zmesh library to be compatible with Zig 0.15.x by removing deprecated usingnamespace declarations and updating various syntax elements. The changes primarily involve moving functionality from the io module to the zcgltf module, updating calling conventions, and modernizing memory allocation patterns.

  • Remove usingnamespace usage and reorganize module structure
  • Update calling conventions from .C to .c and use new @extern syntax with .is_dll_import
  • Modernize data structures to use unmanaged versions and update alignment syntax

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/zcgltf.zig Moves functions from io.zig and updates calling conventions to .c
src/memory.zig Updates @extern declarations with new syntax and modernizes alignment handling
src/io.zig Removes usingnamespace and delegates to zcgltf module
src/Shape.zig Updates ArrayList usage to use explicit allocator parameter
build.zig.zon Updates minimum Zig version requirement to 0.15.1
build.zig Modernizes build script syntax and library creation
README.md Updates examples to use unmanaged data structures

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hazeycode hazeycode merged commit cfcabe1 into zig-gamedev:main Aug 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants