Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 464 Update Compliance Info #467

Merged
merged 54 commits into from
May 8, 2023
Merged

Issue 464 Update Compliance Info #467

merged 54 commits into from
May 8, 2023

Conversation

lazizcodesatdsr
Copy link
Collaborator

@lazizcodesatdsr lazizcodesatdsr commented Apr 11, 2023 •
edited
Loading

Implemented a new transaction for updating ComplianceInfo record.

  • CLI usage: dcld tx compliance update-compliance-info ...

Issue #464

ashcherbakov
ashcherbakov reviewed Apr 13, 2023
View reviewed changes
Copy link
Contributor

@ashcherbakov ashcherbakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also don't forget to update documentation (transactions.md)

proto/compliance/tx.proto Show resolved Hide resolved
proto/compliance/tx.proto Outdated Show resolved Hide resolved
x/compliance/types/message_update_compliance_info.go Show resolved Hide resolved
x/compliance/keeper/msg_server_update_compliance_info.go Outdated Show resolved Hide resolved
proto/compliance/tx.proto Outdated Show resolved Hide resolved
ashcherbakov
ashcherbakov requested changes Apr 13, 2023
View reviewed changes
x/compliance/handler_test.go Outdated Show resolved Hide resolved
integration_tests/cli/compliance-demo.sh Outdated Show resolved Hide resolved
x/compliance/handler_test.go Show resolved Hide resolved
@ashcherbakov
Copy link
Contributor

Also, please put a summary of what fields are mutable and what are immutable into #464 as a comment.

@lazizcodesatdsr lazizcodesatdsr marked this pull request as draft April 13, 2023 18:15
ashcherbakov
ashcherbakov requested changes Apr 26, 2023
View reviewed changes
proto/compliance/tx.proto Outdated Show resolved Hide resolved
x/compliance/types/errors.go Outdated Show resolved Hide resolved
x/compliance/types/message_update_compliance_info.go Outdated Show resolved Hide resolved
integration_tests/grpc_rest/compliance/helpers.go Show resolved Hide resolved
x/compliance/handler_test.go Show resolved Hide resolved
x/compliance/handler_test.go Show resolved Hide resolved
ashcherbakov
ashcherbakov reviewed May 2, 2023
View reviewed changes
docs/transactions.md Outdated Show resolved Hide resolved
x/compliance/types/message_update_compliance_info_test.go Show resolved Hide resolved
x/compliance/types/message_update_compliance_info.go Outdated Show resolved Hide resolved
x/compliance/handler_test.go Outdated Show resolved Hide resolved
x/compliance/keeper/msg_server_update_compliance_info.go Outdated Show resolved Hide resolved
x/compliance/keeper/msg_server_update_compliance_info.go Outdated Show resolved Hide resolved
x/compliance/handler_test.go Show resolved Hide resolved
x/compliance/handler_test.go Show resolved Hide resolved
x/compliance/handler_test.go Show resolved Hide resolved
@ashcherbakov ashcherbakov merged commit f10ae42 into master May 8, 2023
@ashcherbakov ashcherbakov deleted the issue-464-update-compliance-info branch May 10, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenisRybas DenisRybas DenisRybas left review comments

@ashcherbakov ashcherbakov ashcherbakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lazizcodesatdsr @ashcherbakov @DenisRybas