Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge SVG polygons into SVG paths to *hopefully* fix cursed rendering #16

Closed
wants to merge 9 commits into from

Conversation

rudedogg
Copy link

I was trying to add the Zig mark as a custom SF Symbol, and the rendering didn't come out quite right. I think this is caused by using polygons instead of paths.

My hope is this PR will fix the "cursed logo rendering":
image
image

All I've done is open each logo in Affinity Designer, and select all the Polygons in each grouping, and click merge. This should have identical "visible" output, but the extra data about how the logo was constructed is now gone:

Before:
image

After:
Screen Shot 2022-06-11 at 10 03 27 AM

@rudedogg
Copy link
Author

This seems to have cleaned things up a little even in the Github diff:
image

Maybe it's specific to how they do things, but it seems like a good sign

@ProkopRandacek
Copy link
Contributor

The split into multiple polygons is on purpose: fe61728. It turns off AA of straight lines. https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/shape-rendering#crispedges

@andrewrk
Copy link
Member

Thanks but this would have made the logo blurry.

@andrewrk andrewrk closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants