Stage2 bit_shifting.zig passing #10532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hejsil
commented
Jan 7, 2022
Snektron
reviewed
Jan 7, 2022
Hejsil
force-pushed
the
stage2-bit-shifting-passing
branch
2 times, most recently
from
5ce7495
to
97f08e3
Compare
Hejsil
commented
Jan 7, 2022
| @@ -2647,7 +2647,7 @@ pub const FuncGen = struct { | |||
| switch (struct_ty.zigTypeTag()) { | |||
| .Struct => { | |||
| var ptr_ty_buf: Type.Payload.Pointer = undefined; | |||
| const llvm_field_index = llvmFieldIndex(struct_ty, field_index, target, &ptr_ty_buf); | |||
| const llvm_field_index = llvmFieldIndex(struct_ty, field_index, target, &ptr_ty_buf).?; | |||
There was a problem hiding this comment.
I'm assuming here that airStructFieldVal should never be emitted when the field is zero sized, as then the result would always be comptime know, so the instruction would never make it to llvm.
resolveTypeForCodegen is called when we needed to resolve a type fully, even through pointer. This commit fully implements this, even through pointer fields on structs and unions. The function has now also been renamed to resolveTypeFully
`runtime_param_index` is used to get the parameter type from `fn_type`, but this variable was not incremented for zero sized parameters, causing two zero sized parameters of different type to cause miss complication.
It is possible for Zig to emit field ptr instructions to fields whos type is zero sized. In this case llvm should return a pointer which points to the next none zero sized parameter.
Hejsil
force-pushed
the
stage2-bit-shifting-passing
branch
from
97f08e3
to
3871d5e
Compare
andrewrk
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required some llvm and struct+union work. Hope I did it right. Each commit contains reasoning for why this change was done