Use InternPool for all types and constant values #15569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheibo
reviewed
May 11, 2023
| /// This is handy if you have a u32 and want a u32 and don't want to take a | ||
| /// detour through many layers of abstraction elsewhere in the std.hash | ||
| /// namespace. | ||
| /// Copied from https://nullprogram.com/blog/2018/07/31/ |
There was a problem hiding this comment.
This article was updated to point to skeeto/hash-prospector#19 for an improved function - skeeto/hash-prospector#19 (comment) or the previous comment on that issue seem to be the latest and greatest:
pub fn uint32(input: u32) u32 {
var x: u32 = input;
x ^= x >> 16;
x *%= 0x21f0aaad;
x ^= x >> 15;
x *%= 0x735a2d97; // or 0xf35a2d97
x ^= x >> 15;
return x;
}
andrewrk
force-pushed
the
intern-pool-3
branch
4 times, most recently
from
1467d31
to
969ad6a
Compare
andrewrk
changed the title
andrewrk
force-pushed
the
intern-pool-3
branch
2 times, most recently
from
7c86b48
to
dc15fa8
Compare
Closed
Instead of doing everything at once which is a hopelessly large task, this introduces a piecemeal transition that can be done in small increments at a time. This is a minimal changeset that keeps the compiler compiling. It only uses the InternPool for a small set of types. Behavior tests are not passing. Air.Inst.Ref and Zir.Inst.Ref are separated into different enums but compile-time verified to have the same fields in the same order. The large set of changes is mainly to deal with the fact that most Type and Value methods now require a Module to be passed in, so that the InternPool object can be accessed.
* hashing * equality * encoding
This required additionally passing the `InternPool` into some AIR methods. Also, implement `Type.isNoReturn` for interned types.
Hopefully this also fixes the non-reproducing CI failures.
This avoids having dangling pointers into `InternPool.string_bytes`.
You must now write '_ = &f' rather than just '_ = f' to ensure a function is compiled into a binary.
These are frequently invalidated whenever a string is interned, so avoid creating pointers to `string_bytes` wherever possible. This is an attempt to fix random CI failures.
|
Here's a regression not covered by behavior tests: |
This is useful for development, as it speeds up the process of getting semantic analysis errors significantly.
|
Another one. Unfortunately requires git lfs to reproduce: |
|
Another one: |
|
perf data point on 2pew:
|
|
perf data point for ghostty:
|
By correctly handling comptime-only types appearing in non-comptime parameters (when the parameter is either anytype or generic), this avoids an index out of bounds later when later filling out `monomorphed_args` using what used to be slightly different logic.
|
perf data point for legend-of-swarkland: peak rss:
perf: |
Long term, linker backends will need to manage their own string tables for things like this because my mandate is: no long-lived pointers allowed in any of the codepaths touched by incremental compilation, so that we can serialize and deserialize trivially. Short term, I solved this with a couple calls to Allocator.dupe, incurring some harmless leaks.
|
perf data point for groove basin: peak RSS:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset is centered around the
InternPooldata structure. Unfortunately, it required reworking a lot of compiler code.The goal of this branch is to get to a mergeable state as soon as possible, so as to stop accumulating conflicts with master branch.
Follow-up enhancements will include:
legacyfield from ValueAir.Inst.Refcan even store InternPool indexes directly, eliminating the AIR tags for constants.val.toAllocatedBytes- likely each callsite can avoid a copy thanks to the intern pool.