windows: detect ANSI support in more terminals #16080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isatty on Windows is implemented as a isCygwinPty call and a GetConsoleMode call, so calling isatty just duplicates the function calls we already need to do in supportsAnsiEscapeCodes.
|
Thanks! |
This was referenced Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revival of #15282
Helps mitigate #15976 (and may be enough to warrant closing that issue if we're fine with the
.windows_apitty.Confighaving slightly different behavior than.escape_codes, see the "Potential solutions" at the bottom of that issue)From #15282 (comment):
The new build runner means that on Windows the
SetConsoleTextAttributecolors are not preserved when a test case fails. In combination with #13816 / #13723, this makes the output forexpectEqualSlicesmuch less useful.With the changes in this PR, the colors are preserved (at least with Windows Terminal).
Before this PR:
After this PR: