add apple chips to arm CPU detection #17837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to properly handle page size when running Linux on Apple Silicon - I don't think we handle this properly atm. |
|
definitely yeah, I believe there's a PR open right now for that so it should hopefully be solved |
andrewrk
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change if someone were to run apple silicon on e.g. Asahi linux zig would never search for apple chips and default to a generic cpu. the part numbers for the M1 and implementer number were found by reading
/proc/cpuinfoon an M1 running asahi linux, the numbers for the M2 i found here which i cannot confirm but the numbers fall in line with the M1 so i think its safe to trust.i can do a follow up for the M3 if/when I can find the info I need and it's added to zigs list of targets