Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in std.debug.dump_hex #20052

Closed
wants to merge 4 commits into from
Closed

Fix bug in std.debug.dump_hex #20052

wants to merge 4 commits into from

Conversation

Arnau478
Copy link
Contributor

Unfortunately, the writer is hard-coded to be stderr, so I wasn't able to write unit tests without introducing breaking changes.

Fixes #20048

andrewrk
andrewrk requested changes Jul 21, 2024
View reviewed changes
Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the writer is hard-coded to be stderr, so I wasn't able to write unit tests without introducing breaking changes.

That's not accurate. You can extract the logic to a function which is tested and takes stderr as a parameter.

@Arnau478 Arnau478 marked this pull request as draft August 14, 2024 13:25
@andrewrk
Copy link
Member

draft status, no updates in 30+ days

@andrewrk andrewrk closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewrk andrewrk andrewrk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

std.debug.dump_hex address on partial line incorrect
2 participants
@Arnau478 @andrewrk