Isolate solaris event completion #20662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event completion framework of Solaris is in some way the Solaris alternative to `kqueue` and `epoll` [1]. It it is, however, specific to Solaris and afaik not implemented anywhere else in that way. Especially, it is not part of POSIX or some libc implementations that I am aware of. Move symbols related to the Solaris event completeion framework (`port_*`) to `solaris.zig` and remove from `posix.zig` and the general `c.zig`. Note that, in case of a Solaris build the respective symbols will be still available by means of `usingnamespace` in `c.zig`. This seems sufficient given that any direct use of the event completion API will anyways only work on Solaris. Especially, in case of `port_t` putting this into `posix.zig` can be considered harmful. It is all to easy to mistake for POSIX's `in_port_t` [2,3], which is semantically wrong. resolves ziglang#20563 [1] Solaris Event Completion: https://web.archive.org/web/20120819060517/http://developers.sun.com/solaris/articles/event_completion.html [2] Not available in `posix.zig` currently. Might be another issue? [3] POSIX standard this is based on: https://pubs.opengroup.org/onlinepubs/9699919799/download/index.html
|
Let's continue discussion on the issue. This PR cannot be merged as-is due to conflicts with #20679. Those conflicts are related; it should indicate how to proceed with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event completion framework of Solaris is in some way the Solaris alternative to
kqueueandepoll[1]. It it is, however, specific to Solaris and afaik not implemented anywhere else in that way. Especially, it is not part of POSIX or some libc implementations that I am aware of.Move symbols related to the Solaris event completeion framework (
port_*) tosolaris.zigand remove fromposix.zigand the generalc.zig.Note that, in case of a Solaris build the respective symbols will be still available by means of
usingnamespaceinc.zig. This seems sufficient given that any direct use of the event completion API will anyways only work on Solaris.Especially, in case of
port_tputting this intoposix.zigcan be considered harmful. It is all to easy to mistake for POSIX'sin_port_t[2,3], which issemantically wrong.
resolves #20563
[1] Solaris Event Completion: https://web.archive.org/web/20120819060517/http://developers.sun.com/solaris/articles/event_completion.html
[2] Not available in
posix.zigcurrently. Might be another issue?[3] POSIX standard this is based on: https://pubs.opengroup.org/onlinepubs/9699919799/download/index.html