Skip to content

Make std.MultiArrayList works with a tuple that containing void #25441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
+16 −1
Closed

Make std.MultiArrayList works with a tuple that containing void #25441

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6a4333e
Fix
youdie323323 Oct 2, 2025
209e685
Ensure deinit, nullable void
youdie323323 Oct 2, 2025
4db30b0
I shoulded just not mark field with comptime
youdie323323 Oct 2, 2025
ebbda52
Nullable test is not needed
youdie323323 Oct 2, 2025
95dd874
void -> comptime field
youdie323323 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion lib/std/multi_array_list.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ pub fn MultiArrayList(comptime T: type) type {
.name = fields[i].name ++ "_ptr",
.type = *fields[i].type,
.default_value_ptr = null,
.is_comptime = fields[i].is_comptime,
.is_comptime = false,
.alignment = fields[i].alignment,
};
break :entry @Type(.{ .@"struct" = .{
Expand Down Expand Up @@ -1082,3 +1082,18 @@ test "orderedRemoveMany" {
list.orderedRemoveMany(&.{0});
try testing.expectEqualSlices(usize, &.{}, list.items(.x));
}

test "value as a tuple that containing comptime field" {
const gpa = testing.allocator;

// Void default to comptime void = {}

var list: MultiArrayList(struct { void }) = .empty;
defer list.deinit(gpa);

try list.append(gpa, .{});

try testing.expectEqual(list.pop().?[0], {});

try testing.expectEqual(list.pop(), null);
}