Feature Request: Hide/Unhide window #2

theseyan · 2022-08-04T16:49:58Z

Hi, I would like to submit a feature request for hiding and un-hiding the webview window (not exiting it).
If possible, it would also be cool to be able to hide the status/title bar on top and have functions to minimize/maximize the window which would allow for a custom title bar made in HTML.

Awesome library, btw!

ikskuh · 2022-08-04T17:10:22Z

If you check out the original header, there's not much i can actually expose:

positron/src/wv/webview.h

Lines 37 to 108 in e8954db

    
           // Creates a new webview instance. If debug is non-zero - developer tools will 
        
           // be enabled (if the platform supports them). Window parameter can be a 
        
           // pointer to the native window handle. If it's non-null - then child WebView 
        
           // is embedded into the given parent window. Otherwise a new window is created. 
        
           // Depending on the platform, a GtkWindow, NSWindow or HWND pointer can be 
        
           // passed here. 
        
           WEBVIEW_API webview_t webview_create(int debug, void *window); 
        
           // Destroys a webview and closes the native window. 
        
           WEBVIEW_API void webview_destroy(webview_t w); 
        
           // Runs the main loop until it's terminated. After this function exits - you 
        
           // must destroy the webview. 
        
           WEBVIEW_API void webview_run(webview_t w); 
        
           // Stops the main loop. It is safe to call this function from another other 
        
           // background thread. 
        
           WEBVIEW_API void webview_terminate(webview_t w); 
        
           // Posts a function to be executed on the main thread. You normally do not need 
        
           // to call this function, unless you want to tweak the native window. 
        
           WEBVIEW_API void 
        
           webview_dispatch(webview_t w, void (*fn)(webview_t w, void *arg), void *arg); 
        
           // Returns a native window handle pointer. When using GTK backend the pointer 
        
           // is GtkWindow pointer, when using Cocoa backend the pointer is NSWindow 
        
           // pointer, when using Win32 backend the pointer is HWND pointer. 
        
           WEBVIEW_API void *webview_get_window(webview_t w); 
        
           // Updates the title of the native window. Must be called from the UI thread. 
        
           WEBVIEW_API void webview_set_title(webview_t w, const char *title); 
        
           // Window size hints 
        
           #define WEBVIEW_HINT_NONE 0  // Width and height are default size 
        
           #define WEBVIEW_HINT_MIN 1   // Width and height are minimum bounds 
        
           #define WEBVIEW_HINT_MAX 2   // Width and height are maximum bounds 
        
           #define WEBVIEW_HINT_FIXED 3 // Window size can not be changed by a user 
        
           // Updates native window size. See WEBVIEW_HINT constants. 
        
           WEBVIEW_API void webview_set_size(webview_t w, int width, int height, 
        
                                             int hints); 
        
           // Navigates webview to the given URL. URL may be a data URI, i.e. 
        
           // "data:text/text,<html>...</html>". It is often ok not to url-encode it 
        
           // properly, webview will re-encode it for you. 
        
           WEBVIEW_API void webview_navigate(webview_t w, const char *url); 
        
           // Injects JavaScript code at the initialization of the new page. Every time 
        
           // the webview will open a the new page - this initialization code will be 
        
           // executed. It is guaranteed that code is executed before window.onload. 
        
           WEBVIEW_API void webview_init(webview_t w, const char *js); 
        
           // Evaluates arbitrary JavaScript code. Evaluation happens asynchronously, also 
        
           // the result of the expression is ignored. Use RPC bindings if you want to 
        
           // receive notifications about the results of the evaluation. 
        
           WEBVIEW_API void webview_eval(webview_t w, const char *js); 
        
           // Binds a native C callback so that it will appear under the given name as a 
        
           // global JavaScript function. Internally it uses webview_init(). Callback 
        
           // receives a request string and a user-provided argument pointer. Request 
        
           // string is a JSON array of all the arguments passed to the JavaScript 
        
           // function. 
        
           WEBVIEW_API void webview_bind(webview_t w, const char *name, 
        
                                         void (*fn)(const char *seq, const char *req, 
        
                                                    void *arg), 
        
                                         void *arg); 
        
           // Allows to return a value from the native binding. Original request pointer 
        
           // must be provided to help internal RPC engine match requests with responses. 
        
           // If status is zero - result is expected to be a valid JSON result value. 
        
           // If status is not zero - result is an error JSON object. 
        
           WEBVIEW_API void webview_return(webview_t w, const char *seq, int status, 
        
                                           const char *result);

I guess for these features you have to either hack all three backends to support these features, but i'll keep positron a flat and simple wrapper around the webview library + an embedded web server for local loopback requests.

theseyan · 2022-08-04T17:31:43Z

Ah, I guess it's better to open this feature request in the upstream webview library then👍

ikskuh added the enhancement New feature or request label Aug 4, 2022

theseyan closed this as completed Aug 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature Request: Hide/Unhide window #2

Feature Request: Hide/Unhide window #2

theseyan commented Aug 4, 2022

ikskuh commented Aug 4, 2022

theseyan commented Aug 4, 2022

Feature Request: Hide/Unhide window #2

Feature Request: Hide/Unhide window #2

Comments

theseyan commented Aug 4, 2022

ikskuh commented Aug 4, 2022

theseyan commented Aug 4, 2022