Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Please read the comment below this on how these PRs should be merged: #17 (comment)
(TL;DR -> this PR first, then restart CI on linked PRs, then mark those as ready and merge when CI passes)
Proposed change
Updates the Codecov action to v4.
This version now requires a Codecov token. This is provided as a different GitHub secret on each zigpy repo.
All individual workflows will need to be updated to pass the
CODECOV_TOKEN
secret to this shared workflow.When a repo is forked, the GitHub secret will return an empty string. (Hopefully, still satisfying the
required
property in this shared workflow -- needs testing first). Codecov v4 detects that it's running on a fork and will use tokenless uploads, ignoring the empty token/secret. These tokenless updates can still hit the global GitHub API rate limit, but at least our repo commits won't.There also seem to be some issues with v3 at the moment where it barely works at all. I'm not sure if they're related to the GH API rate limit or by some codecov issue, but v4 seems to work a lot better, even with tokenless uploads. (tested in HA repo)
Corresponding PRs for all repos using the shared workflow: