Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Codecov v4 changes #3105

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Support Codecov v4 changes #3105

merged 1 commit into from
Apr 11, 2024

Conversation

TheJulianJES
Copy link
Collaborator

@TheJulianJES TheJulianJES commented Apr 11, 2024

DRAFT -- do not merge yet (needs below workflow PR merged first, CI will fail for now)

Proposed change

Passes the CODECOV_TOKEN GH secret to the shared workflow.

Additional information

Related PR:

This PR is on a branch in the main repo, not on a fork, so the CODECOV_TOKEN secret is available and Codecov uses the upload variant with the token. See this run with token.
For PRs created from a fork, Codecov recognized that and automatically switches to the tokenless upload. See this run without token.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.91%. Comparing base (9ccb69a) to head (18b0372).
Report is 6 commits behind head on dev.

❗ Current head 18b0372 differs from pull request most recent head 81845ef. Consider uploading reports for the commit 81845ef to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3105   +/-   ##
=======================================
  Coverage   87.90%   87.91%           
=======================================
  Files         300      300           
  Lines        9222     9226    +4     
=======================================
+ Hits         8107     8111    +4     
  Misses       1115     1115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES reopened this Apr 11, 2024
@TheJulianJES TheJulianJES marked this pull request as ready for review April 11, 2024 15:38
@TheJulianJES TheJulianJES merged commit 12dd80d into dev Apr 11, 2024
6 checks passed
@TheJulianJES TheJulianJES deleted the tjj/codecov_v4 branch April 11, 2024 15:38
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
Pass `CODECOV_TOKEN` to shared workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant