Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unitec Valve Thermostat #1000

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Add Unitec Valve Thermostat #1000

merged 2 commits into from
Aug 25, 2021

Conversation

idstein
Copy link
Contributor

@idstein idstein commented Aug 18, 2021

Adding another Tuya valve variant
https://zigbee.blakadder.com/Unitec_30946.html

#  endpoint=1 profile=260 device_type=81 device_version=0 input_clusters=[0, 4, 5, 61184]
#  output_clusters=[10, 25]>

Adding another Tuya valve variant
https://zigbee.blakadder.com/Unitec_30946.html

```
#  endpoint=1 profile=260 device_type=81 device_version=0 input_clusters=[0, 4, 5, 61184]
#  output_clusters=[10, 25]>
```
@idstein
Copy link
Contributor Author

idstein commented Aug 18, 2021

This valve also has a window opening detection. So it might also be a variant of MoesHY368_Type1, but it looks absolutely identical to Revolt NX4911 (implemented as SiterwellGS361_Type2) https://zigbee.blakadder.com/Revolt_NX-4911.html.

But the Revolt NX4911 also has a window detection built-in according to the German webpage see https://www.revolt-power.de/Weltweit-steuerbares-Heizkoerper-Design-Thermostat-NX-4911-919.shtml

@MattWestb
Copy link
Contributor

Z2M have adding it as one SiterwellGS361 and i have not seen any complains that is not working OK in there issues.

You can also adding the Manufacture ID on the type 1 then normally its coming one upgraded version with the other zigbee module and then must doing on more PR.

("_TYST11_ps5v5jor", "s5v5jor"),

I have adding it in the tuya TRV matrix as its in the pipe :-))

@coveralls
Copy link

coveralls commented Aug 25, 2021

Pull Request Test Coverage Report for Build 1166242228

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.619%

Totals Coverage Status
Change from base Build 1166235051: 0.0%
Covered Lines: 3993
Relevant Lines: 4833

💛 - Coveralls

@dmulcahey
Copy link
Collaborator

Needs conflicts resolved

@idstein
Copy link
Contributor Author

idstein commented Aug 25, 2021

Needs conflicts resolved

Done.

@dmulcahey
Copy link
Collaborator

Thanks!

@dmulcahey dmulcahey merged commit 4f868ee into zigpy:dev Aug 25, 2021
dmulcahey pushed a commit that referenced this pull request Aug 25, 2021
Type 2 is added in #1000 but the type 1 was not added so i putting it in so the user have it working out of the box then its shoeing up.
("_TYST11_ps5v5jor", "s5v5jor"),
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants