Improve support for sinope Calypso and Eco Mode

[claudegel]

Proposed change

• Code cleanup for calypso controller.
• Add support for Eco Mode on thermostats, Eco Sinopé
• Add many attributes for sensor and light in manufacturer cluster

Additional information

Checklist

• The changes are tested and work correctly
• pre-commit checks pass / the code has been formatted using Black
• Tests have been added to verify that the new code works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5291121) 87.37% compared to head (c449552) 87.37%.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #2829      +/-   ##
==========================================
- Coverage   87.37%   87.37%   -0.01%     
==========================================
  Files         287      287              
  Lines        8847     8845       -2     
==========================================
- Hits         7730     7728       -2     
  Misses       1117     1117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[claudegel]

It was an error as the TankSize finally is not in the attribute but only in Neviweb cloud. It is not used by the Calypso. I've left the attribute there as other could be able to find out the usage.
I have many other attribute that are still unknown. is it better to leave them out until I find the usage or put them in the quirks so other have access to play with them.

[claudegel]

Another thing, I'm thinking of splitting the 4 files into specific file for each device model. Could it be better ? It's a big job to separate everything but if it is better I can try to split them.

[TheJulianJES]

I'm thinking of splitting the 4 files into specific file for each device model.

Generally yeah, it's nicer to have different device types separated. For example, switch.py has smart plugs, valve controllers, ... from what I can see. IMO, it's still fine for these, as there aren't too many models, but we're open for a "cleanup PR" if you want.

[TheJulianJES]

LGTM

[claudegel]

I have many attributes found in manufacturer cluster but still need to find out the use. Generally I don't add them to the quirks but could it be better to add them as unknown_attr_xx so other can try to understand the usage for them so we can put a name on them ?

[TheJulianJES]

many attributes found in manufacturer cluster but still need to find out the use. Generally I don't add them to the quirks but could it be better to add them as unknown_attr_xx

I don't have a real preference. If they're likely not needed, I wouldn't add them, but it should also be fine if you do add them.