-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix instantaneous demand on Schneider Wiser outlets #2836
Conversation
Based on the code supplied by krlssn in comment zigpy#1889 (comment)
tweaked output clusters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2836 +/- ##
==========================================
+ Coverage 87.37% 87.58% +0.20%
==========================================
Files 287 295 +8
Lines 8848 9013 +165
==========================================
+ Hits 7731 7894 +163
- Misses 1117 1119 +2 ☔ View full report in Codecov by Sentry. |
Also I would love some guidance on how I can test this on my HA Green that I'm running. Do I compile and upload as a custom component? I'd rather not screw it up since it works wonderfully at the moment, except for this little pesky thing with how numbers are reported :) |
You can take a look at https://community.home-assistant.io/t/how-to-setup-local-zha-quirks/341226 on how to setup using a custom quirk. |
Also check out this PR with an end-user how-to guide for the readme -> #2419 + this other discussion here -> #2467 |
@kosmiq Were you able to get this running and verify that it works for your plugs (by installing the file as a custom quirk)? |
Pushed some small changes. This can be tested as a custom quirk using this: #1889 (comment) |
Hi! Not yet. It’s on my radar but life got in the way with Christmas and all. Still looking to find the time. Thanks for the cleanup and adding the tests! Much appreciated |
Tested here: #1889 (comment) So, should be fine. Tests are also added. |
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
Based on the code supplied by krlssn in comment #1889 (comment)
I'm VERY new to the whole Python world so I feel totally lost when it comes to writing tests and honestly not capable of doing so currently. I'm currently trying to get a dev env setup with Python 3.12 but I get weird errors regarding building wheels and whatnot. I'll see if I can get that running...
Proposed change
Additional information
<SimpleDescriptor...>
based on log information obtained via HA. I also attempted to verify other information by comparing to my 2-way Wiser outlet.Checklist
pre-commit
checks pass / the code has been formatted using Black