Add PM2.5 for Tuya Smart Air House keeper #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: zhaquirks/tuya/air/ts0601_air_quality.py new file: zhaquirks/tuya/air/ts0601_smart_air.py
modified: zhaquirks/tuya/air/ts0601_air_quality.py new file: zhaquirks/tuya/air/ts0601_smart_air.py modified: tests/test_tuya_air.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2837 +/- ##
==========================================
+ Coverage 87.37% 87.39% +0.01%
==========================================
Files 287 288 +1
Lines 8848 8860 +12
==========================================
+ Hits 7731 7743 +12
Misses 1117 1117 ☔ View full report in Codecov by Sentry. |
TheJulianJES
changed the title
TheJulianJES
approved these changes
Dec 23, 2023
| replacement = { | ||
| ENDPOINTS: { | ||
| 1: { | ||
| DEVICE_TYPE: zha.DeviceType.ON_OFF_LIGHT, |
There was a problem hiding this comment.
Noticed ON_OFF_LIGHT as a type when reviewing. The previous/other Tuya "air-related" quirks also use this, so I guess it's fine/there's a reason, but we might wanna take a look at this in the future again.
elupus
pushed a commit
to elupus/zha-device-handlers
that referenced
this pull request
Jan 17, 2024
lgraf
pushed a commit
to lgraf/zha-device-handlers
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add capability to read PM25 values from Tuya Smart House keeper devices and split device into separate quirk.
This is my first pull request ever and also a first attempt at python so any guidance is appreciated.
Additional information
also synced the supported models with those supported by Zigbee2MQTT
Checklist
pre-commitchecks pass / the code has been formatted using Black