Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IKEA Somrig shortcut button #2844

Merged
merged 2 commits into from
Dec 23, 2023

Conversation

casparz
Copy link
Contributor

@casparz casparz commented Dec 18, 2023

Proposed change

Quirk for new SOMRIG smart button from IKEA. I based everything off of the Symfonysk remote v2.

Additional information

Fixes #2835

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0c4109) 87.37% compared to head (d0f30f0) 87.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2844      +/-   ##
==========================================
+ Coverage   87.37%   87.38%   +0.01%     
==========================================
  Files         287      288       +1     
  Lines        8848     8858      +10     
==========================================
+ Hits         7731     7741      +10     
  Misses       1117     1117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the new quirk Adds support for a new device label Dec 18, 2023
@casparz casparz marked this pull request as ready for review December 18, 2023 12:30
@joshuapfl
Copy link

does it work now?

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@TheJulianJES TheJulianJES changed the title Create quirk for somrig smart button Add support for IKEA Somrig shortcut button Dec 20, 2023
@TheJulianJES TheJulianJES merged commit 4ca532a into zigpy:dev Dec 23, 2023
14 checks passed
elupus pushed a commit to elupus/zha-device-handlers that referenced this pull request Jan 17, 2024
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
@hugomn
Copy link

hugomn commented Oct 10, 2024

Hi @casparz! Is there any chance you could test the SOMRIG implementation again? As you can see here, it seems like no IKEA devices have been working anymore for a few weeks.

@MattWestb
Copy link
Contributor

Deleted waiting one minute and adding it as new and i getting:

IKEA SOMRIG shortcut button Remote Button Double Press - Button 1 event was fired with parameters: {'previous_position': 0, 'total_number_of_presses_counted': 2}
15:44:31 - Now

Coordinator EZSP with blocked direct children.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quirk Adds support for a new device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Ikea Somrig button, not able to connect zha
5 participants