Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aqara P1 contact sensor: fix typo in attributes #2866

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Conversation

matttbe
Copy link
Contributor

@matttbe matttbe commented Dec 28, 2023

Proposed change

A l was missing in millimeters attributes of the new Aqara P1 contact sensor quirk.

Additional information

The typo was introduced in #2822.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

A 'l' was missing in 'millimeters' attributes.
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (feaa5d3) 87.50% compared to head (2486359) 87.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2866   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files         292      292           
  Lines        8952     8952           
=======================================
  Hits         7833     7833           
  Misses       1119     1119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmulcahey dmulcahey merged commit a2911a0 into zigpy:dev Dec 28, 2023
14 checks passed
elupus pushed a commit to elupus/zha-device-handlers that referenced this pull request Jan 17, 2024
A 'l' was missing in 'millimeters' attributes.
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
A 'l' was missing in 'millimeters' attributes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants