Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add battery level for frient Entry Sensor and Entry Sensor Pro #2876

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Add battery level for frient Entry Sensor and Entry Sensor Pro #2876

merged 4 commits into from
Jan 5, 2024

Conversation

danielpetrovic
Copy link
Contributor

@danielpetrovic danielpetrovic commented Jan 1, 2024

Added battery level support for frient Entry Sensor and Entry Sensor Pro.

Proposed change

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Added battery level support for frient Entry Sensor and Entry Sensor Pro.
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf06668) 87.50% compared to head (e90f493) 87.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2876   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files         292      292           
  Lines        8952     8959    +7     
=======================================
+ Hits         7833     7840    +7     
  Misses       1119     1119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MattWestb
Copy link
Contributor

Black like have one space between:

-        MODELS_INFO: [(DEVELCO, "WISZB-121"),(FRIENT, "WISZB-121")],
+        MODELS_INFO: [(DEVELCO, "WISZB-121"), (FRIENT, "WISZB-121")],

@danielpetrovic
Copy link
Contributor Author

danielpetrovic commented Jan 1, 2024

How can I fix this in the current pull request?

@danielpetrovic danielpetrovic changed the title Update open_close.py Add frient Entry Sensor and frient Entry Sensor Pro (battery level support) Jan 1, 2024
@MattWestb
Copy link
Contributor

MattWestb commented Jan 1, 2024

Do new edetings in your "local" git (danielpetrovic:patch-1) and then saving it its asking if like posting it directly or later and you can getting the pull being updated.

Fix some spaces and comments.
@danielpetrovic
Copy link
Contributor Author

danielpetrovic commented Jan 1, 2024

Do new edetings in your "local" git (danielpetrovic:patch-1) and then saving it its asking if like posting it directly or later and you can getting the pull being updated.

Thanks, I’ve pushed it again within patch-1 and fixed all the things it suggested. The check finished fully now.

Comment formatting.
Formatting error.
@TheJulianJES TheJulianJES changed the title Add frient Entry Sensor and frient Entry Sensor Pro (battery level support) Add battery level for frient Entry Sensor and Entry Sensor Pro Jan 5, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@TheJulianJES TheJulianJES merged commit ee04e31 into zigpy:dev Jan 5, 2024
14 checks passed
@TheJulianJES TheJulianJES added the new quirk Adds support for a new device label Jan 5, 2024
elupus pushed a commit to elupus/zha-device-handlers that referenced this pull request Jan 17, 2024
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quirk Adds support for a new device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants