Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for zigpy TSN changes #2885

Merged

Conversation

TheJulianJES
Copy link
Collaborator

Proposed change

This updates zha-quirks tests to account for the per-device TSNs in zigpy 0.60.3 and later.
The tests do not pass without this change when using zigpy 0.60.3 or later.

The minimum required zigpy version is also bumped to 0.60.3, although only the tests "need" this.

Additional information

cc @puddly

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b9516d) 87.56% compared to head (c01269e) 87.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2885   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files         293      293           
  Lines        8997     8997           
=======================================
  Hits         7878     7878           
  Misses       1119     1119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES
Copy link
Collaborator Author

cc @dmulcahey
The zigpy per-device TSN PR from some weeks ago broke quirks tests when using a newer zigpy version (>=0.60.3).

I think the GitHub CI currently only passes because it uses an older version (cached environment).
I've also bumped the minimum required zigpy version in this PR. It's only really required for tests (and forcing GH Actions to not use the old cache I guess), but bumping that should be fine, right?

@TheJulianJES TheJulianJES merged commit 20484aa into zigpy:dev Jan 19, 2024
14 checks passed
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants