-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sonoff SNZB-06P presence sensor support #2895
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2895 +/- ##
==========================================
+ Coverage 87.56% 87.60% +0.04%
==========================================
Files 293 295 +2
Lines 8997 9030 +33
==========================================
+ Hits 7878 7911 +33
Misses 1119 1119 ☔ View full report in Codecov by Sentry. |
@TheJulianJES just wanted to check if there is anything more I need to do with this quirk before it can be reviewed? If its just in the queue, all good and apologies for the ping :) |
It's still on my list to review. The changes look good from a quick glance though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Proposed change
Improving the support for the Sonoff SNZB-06P
Main changes by this quirk:
Additional information
Thanks to @theorlangur and their work on #2869.
When combined with home-assistant/core#107379, solves #2702
Checklist
pre-commit
checks pass / the code has been formatted using Black