Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sonoff SNZB-06P presence sensor support #2895

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

peterkh
Copy link
Contributor

@peterkh peterkh commented Jan 9, 2024

Proposed change

Improving the support for the Sonoff SNZB-06P

Main changes by this quirk:

  • remove redundant IaS Zone cluster as it doesn't provide anything useful that is not already provided from the Occupancy cluster and removes a second entity being created.
  • Adds support for Sonoff specific cluster which has the illumination state (Light or Dark) when presence was last detected.

Additional information

Thanks to @theorlangur and their work on #2869.

When combined with home-assistant/core#107379, solves #2702

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b9516d) 87.56% compared to head (cd848f1) 87.60%.
Report is 7 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2895      +/-   ##
==========================================
+ Coverage   87.56%   87.60%   +0.04%     
==========================================
  Files         293      295       +2     
  Lines        8997     9030      +33     
==========================================
+ Hits         7878     7911      +33     
  Misses       1119     1119              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterkh
Copy link
Contributor Author

peterkh commented Jan 16, 2024

@TheJulianJES just wanted to check if there is anything more I need to do with this quirk before it can be reviewed? If its just in the queue, all good and apologies for the ping :)

@TheJulianJES
Copy link
Collaborator

It's still on my list to review. The changes look good from a quick glance though.

@TheJulianJES TheJulianJES added the new quirk Adds support for a new device label Jan 16, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TheJulianJES TheJulianJES merged commit 0b19318 into zigpy:dev Jan 24, 2024
14 checks passed
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quirk Adds support for a new device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants