Update Tuya RCBO quirk power factor calculation for home-assistant/core#107641 #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeverley
changed the title
jeverley
changed the title
Merged
20 tasks
jeverley
force-pushed
the
power_factor_calculation_correct
branch
from
04c1ec9 to
6c7cfe2
Compare
TheJulianJES
changed the title
|
The Tuya quirks tests probably need to be corrected to expect the new value then. See:
(and ideally, the HA PR needs to have tests for the added code) |
Amend power_factor calculation to respect Zigbee cluster specification - required for release of zha fix: home-assistant/core#107641
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2896 +/- ##
==========================================
+ Coverage 87.58% 87.60% +0.02%
==========================================
Files 294 295 +1
Lines 9010 9030 +20
==========================================
+ Hits 7891 7911 +20
Misses 1119 1119 ☔ View full report in Codecov by Sentry. |
jeverley
force-pushed
the
power_factor_calculation_correct
branch
from
2180278 to
3c44240
Compare
|
@TheJulianJES once you are good with this you can merge this and the corresponding HA PR: home-assistant/core#107641 |
TheJulianJES
approved these changes
Jan 24, 2024
lgraf
pushed a commit
to lgraf/zha-device-handlers
that referenced
this pull request
May 6, 2024
…re#107641 (zigpy#2896) Amend power_factor calculation to respect Zigbee cluster specification - required for release of ZHA fix: home-assistant/core#107641
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Amend power_factor calculation to respect Zigbee cluster specification - required for release of zha fix:
home-assistant/core#107641
Additional information
This updates the power factor calculation to multiply by 100 rather than 1000, this is because the ElectricalMeasurement attribute is supposed to expose values between -100 and 100 (see the pre-requisite PR 107641 for details).
The current code exposes values between 0 and 1000, which is subsequently divided by 10 due to the behaviour of the zha cluster sensor corrected in home-assistant/core#107641
If released without home-assistant/core#107641 the value reported will be an order of magnitude too low.
Checklist
pre-commitchecks pass / the code has been formatted using Black