Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya _TZE204_yjjdcqsq temp sensor variant #2902

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Add Tuya _TZE204_yjjdcqsq temp sensor variant #2902

merged 1 commit into from
Jan 17, 2024

Conversation

scop
Copy link
Contributor

@scop scop commented Jan 10, 2024

Proposed change

SSIA.

Additional information

After some more local testing (see #2899), just adding this to the "variant 4" appears to make it work. Things update slowly, but temperature readings look eventually ok, battery is as expected. Humidity is almost 10% off compared to some other devices I have around (showing e.g. 34% when the others show ~42%).

Fixes #2899

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b9516d) 87.56% compared to head (4e52b70) 87.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2902   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files         293      293           
  Lines        8997     8997           
=======================================
  Hits         7878     7878           
  Misses       1119     1119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Jan 15, 2024
@TheJulianJES TheJulianJES changed the title Add Tuya _TZE204_yjjdcqsq sensor variant Add Tuya _TZE204_yjjdcqsq temp sensor variant Jan 17, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES merged commit b68f0d0 into zigpy:dev Jan 17, 2024
14 checks passed
@scop scop deleted the feat/_TZE204_yjjdcqsq branch January 19, 2024 10:58
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] TS0601 _TZE204_yjjdcqsq temperature/humidity sensor
2 participants