-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zbeacon DS01 quirk removing PollControl
cluster
#2913
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2913 +/- ##
==========================================
+ Coverage 87.56% 87.57% +0.01%
==========================================
Files 293 294 +1
Lines 8997 9005 +8
==========================================
+ Hits 7878 7886 +8
Misses 1119 1119 ☔ View full report in Codecov by Sentry. |
With witch coordinator do you have testing and also is you having one sniffing of the pairing that we can taking one look on. Edit: I have not seen any tuya end device using pull control and checkins only good working ones real Zigbee 3 that is doing it well is IKEA with current production firmware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small comments.
(Note for the next time, we also have an experimental "quirk-generator" to generate a quirk that just matches a device based on the provided signature/diagnostics file.)
PollControl
cluster
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
@TheJulianJES Great that there is a tool to generate quirks now, nice job. @MattWestb My coordinator is a Conbee II with the latest firmware (15-May-2022). The testing is done with 2 devices and I have consistent errors with both every ~45 minutes without this quirk (even after re-pairing). I could send a log, but it'll take a little while for me to get around to it. About the classification: I wasn't sure where to put it, because it is unclear to me who made it. The sellers advertise it as being TuYa. I could move it to Elivco or IHseno IH-MC01 (both seem identical in the pictures, but mine are from Elivco). |
Then its not one TI-Coordinator problem then one tuya is trying implanting pull control and more then likely we is getting more device from them with the same problem very sooooooon. |
I moved it to its own manufacturer for now; I just put it under Zbeacon. It is probably using a TuYa ZTU module, but that doesn't mean it's programmed by TuYa. I cannot find anything about Zbeacon, Elivco or IHsense. Although Elivco seems to yield some results with smart plugs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think it's fine to have it separated from Tuya, as it doesn't seem to be from Tuya at first glance at least. We can always move it later of course.
--------- Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
Proposed change
The Zbeacon DS01 (no idea who made this, but it's a cheap chinese door sensor that runs on 2xAAA and is long rectangular in shape).
Add quirk for Zbeacon DS01, which removes the PollControl cluster, which is incorrectly implemented by the device I think.
Additional information
The device will send "PollControl:checkin()" on PollControl cluster, but doesn't respond when checkin_response is sent after that from the coordinator.
This results in error messages every 30-60 minutes with the message that the device didn't respond.
This is easily avoided by just disabling the PollControl Cluster.
Checklist
pre-commit
checks pass / the code has been formatted using Black