Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sinope clusters blocking some attribute updates #2930

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

TheJulianJES
Copy link
Collaborator

Proposed change

This fixes an issue where other attributes on the custom Sinope clusters were not updating.
Tests are also added to verify this is working.

Additional information

I'm not sure if other attributes are actually used though, but we should still fix it.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@TheJulianJES TheJulianJES added the bugfix This PR fixes a bug label Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (729bffd) 87.58% compared to head (928218b) 87.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2930   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files         294      294           
  Lines        9010     9012    +2     
=======================================
+ Hits         7891     7893    +2     
  Misses       1119     1119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES merged commit 04ac526 into zigpy:dev Jan 24, 2024
14 checks passed
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant