Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Tuya spell tests #2941

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

TheJulianJES
Copy link
Collaborator

@TheJulianJES TheJulianJES commented Jan 27, 2024

Proposed change

This moves spell-related Tuya tests from test_tuya.py to test_tuya_spells.py.

(The diff may look huge, but there are no code changes, other than moving the tests.)

Additional information

This moves Tuya spells tests as mentioned in this related PR:

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

This moves spell-related Tuya tests from `test_tuya.py` to `test_tuya_spells.py`.
@TheJulianJES TheJulianJES added Tuya Request/PR regarding a Tuya device code quality Improvement to code quality labels Jan 27, 2024
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c55555e) 87.62% compared to head (21f3ddf) 87.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2941   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files         295      295           
  Lines        9045     9045           
=======================================
  Hits         7926     7926           
  Misses       1119     1119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES merged commit 431ae4d into zigpy:dev Jan 27, 2024
14 checks passed
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
This moves spell-related Tuya tests from `test_tuya.py` to `test_tuya_spells.py`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvement to code quality Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant