-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to new Tuya EnchantedDevice
import path
#2942
Change to new Tuya EnchantedDevice
import path
#2942
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2942 +/- ##
==========================================
- Coverage 87.62% 87.62% -0.01%
==========================================
Files 295 295
Lines 9045 9039 -6
==========================================
- Hits 7926 7920 -6
Misses 1119 1119 ☔ View full report in Codecov by Sentry. |
It seems that this commit has messed something with tuya/ts001x.py as my devices stopped working. Reverting to the quirk from previous tag fixed my issue. If any more information is needed I can provide any logs/traces/anything |
@jesuslobo Can you describe what setup you're using? (Custom quirks?) |
My previous custom quirks were:
Maybe (probably) outdated, but working AFAIK. Yesterday i've to add tuya/ts001x.py to get it working again. I'm out now, but if you need any other info, I can provide it when at home. |
Those custom quirks are all included in HA already. You should not need to use any custom quirks. |
Latest, I check daily for docker image updates dia watchtower. I can't exactly remember why I had to use custom quirks for those items (they are from past year aug/sep), possibly because some upgrade related malfunction like yesterday's ts001x HA Versions: |
`EnchantedDevice` is now imported from `zhaquirks.tuya`, rather than from `zhaquirks.tuya.mcu`.
Proposed change
This changes the imports for the
EnchantedDevice
class from the old path to the new path:Additional information
This changes the imports to the new
EnchantedDevice
path as mentioned in this related PR:As mentioned in that PR, it's still impossible to import
EnchantedDevice
fromzhaquirks.tuya.mcu
in order to keep backwards compatibility with custom quirks that haven't updated.But it only makes sense to update zha-quirks to import from the "correct"/new location already, hence this PR.
Checklist
pre-commit
checks pass / the code has been formatted using Black