Fix Sinope custom attribute values #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2963 +/- ##
=======================================
Coverage 87.68% 87.68%
=======================================
Files 297 297
Lines 9084 9087 +3
=======================================
+ Hits 7965 7968 +3
Misses 1119 1119 ☔ View full report in Codecov by Sentry. |
TheJulianJES
changed the title
|
I see that ZHA is creating sensors for attributes that are doing reporting. Can you point me on where to look to learn how to do that for my other components. Thank you |
lgraf
pushed a commit
to lgraf/zha-device-handlers
that referenced
this pull request
May 6, 2024
* Fix wrong definition for attribute values * Add Partial_lock value for keypadLock * Add battery_type attribute * Add Partial_lock and Bedroom attributes values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add/fix some attributes value in manufacturer and thermostat clusters. Add battery_type attribute sensors.
Additional information
Just small changes
Checklist
pre-commitchecks pass / the code has been formatted using Black