Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tuya temperature sensor variants #2967

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Conversation

maxustm
Copy link
Contributor

@maxustm maxustm commented Feb 8, 2024

replace "_TZE200_utkemkbs" to var4 and add new one "_TZE204_utkemkbs" (Roximo's T&H sensors)

replace "_TZE200_utkemkbs" to var4 and add "_TZE204_utkemkbs" (Roximo's T&H sensors)
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab0d248) 87.68% compared to head (7d17e24) 87.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2967   +/-   ##
=======================================
  Coverage   87.68%   87.68%           
=======================================
  Files         297      297           
  Lines        9087     9087           
=======================================
  Hits         7968     7968           
  Misses       1119     1119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES changed the title Update ts0601_sensor.py Update Tuya temp sensor variants Feb 9, 2024
@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Feb 9, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Are the changes tested and working for both sensors?
Also, why did the _TZE200_utkemkbs need to move from Var03 to Var04?

@maxustm
Copy link
Contributor Author

maxustm commented Feb 10, 2024

Thanks for the PR! Are the changes tested and working for both sensors? Also, why did the _TZE200_utkemkbs need to move from Var03 to Var04?

Move to var4 - to support battery information.
Both sensors have been tested and work normal.

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES changed the title Update Tuya temp sensor variants Update Tuya temperature sensor variants Feb 11, 2024
@TheJulianJES TheJulianJES merged commit 6cddacc into zigpy:dev Feb 11, 2024
14 checks passed
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
- move `_TZE200_utkemkbs` to var4 to support battery information
- add `_TZE204_utkemkbs` (Roximo's T&H sensors)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants