-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tuya temperature sensor variants #2967
Conversation
replace "_TZE200_utkemkbs" to var4 and add "_TZE204_utkemkbs" (Roximo's T&H sensors)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2967 +/- ##
=======================================
Coverage 87.68% 87.68%
=======================================
Files 297 297
Lines 9087 9087
=======================================
Hits 7968 7968
Misses 1119 1119 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Are the changes tested and working for both sensors?
Also, why did the _TZE200_utkemkbs
need to move from Var03
to Var04
?
Move to var4 - to support battery information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
- move `_TZE200_utkemkbs` to var4 to support battery information - add `_TZE204_utkemkbs` (Roximo's T&H sensors)
replace "_TZE200_utkemkbs" to var4 and add new one "_TZE204_utkemkbs" (Roximo's T&H sensors)