Improve IKEA battery percentage firmware detection #2998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2998 +/- ##
=======================================
Coverage 87.85% 87.85%
=======================================
Files 301 301
Lines 9212 9217 +5
=======================================
+ Hits 8093 8098 +5
Misses 1119 1119 ☔ View full report in Codecov by Sentry. |
TheJulianJES
commented
Feb 24, 2024
| def _is_firmware_old(self): | ||
| """Checks if firmware is old or unknown.""" | ||
| def _is_firmware_new(self): | ||
| """Checks if new firmware is installed that does not require battery doubling.""" | ||
| # get sw_build_id from attribute cache if available | ||
| sw_build_id = self.endpoint.basic.get(Basic.AttributeDefs.sw_build_id.id, None) |
There was a problem hiding this comment.
Suggested change
| sw_build_id = self.endpoint.basic.get(Basic.AttributeDefs.sw_build_id.id, None) | |
| sw_build_id = self.endpoint.basic.get(Basic.AttributeDefs.sw_build_id.id) |
For a future PR: None is already the default for zigpy clusters, so we can remove that.
3 tasks
lgraf
pushed a commit
to lgraf/zha-device-handlers
that referenced
this pull request
May 6, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This improves the detection mechanism for IKEA firmware.
Previously, it detected versions that started with
24or higher as new. Everything else was treated as old and doubled.This was fine mostly. However, one IKEA remote already uses
2.4.xfirmware which no longer requires doubling.So this PR now checks the first two parts of the
sw_build_id(split by.) for the firmware version.Possible upcoming formattings of that string are treated as new too (so no doubling).
Basically, the doubling is now not applied if the firmware is 2.4.x or newer.
Additional information
Fixes #2977
Checklist
pre-commitchecks pass / the code has been formatted using Black