Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KeenHome smart vent SV02-410-MP-1.2 #3002

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

Cyberax
Copy link
Contributor

@Cyberax Cyberax commented Feb 26, 2024

Adding a missing signature for a KeenHome smart vent. It appears to behave exactly like the other KeenHome vents.

Proposed change

Add a missing signature

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Adding a missing signature for a KeenHome smart vent. It appears to
behave exactly like the other KeenHome vents.
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.85%. Comparing base (fc1e55f) to head (5cb0d05).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3002   +/-   ##
=======================================
  Coverage   87.85%   87.85%           
=======================================
  Files         301      301           
  Lines        9217     9217           
=======================================
  Hits         8098     8098           
  Misses       1119     1119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES changed the title Add more KeenHome smart vent signatures Add KeenHome smart vent SV02-410-MP-1.2 Feb 26, 2024
@TheJulianJES TheJulianJES merged commit e4d0663 into zigpy:dev Feb 26, 2024
14 checks passed
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants