Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Inovelli VZM35-SN fw 1.07 support #3003

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

InovelliUSA
Copy link
Contributor

Proposed change

Adding an additional signature as the keep-alive cluster was added in firmware 1.07

Additional information

This should not break anything as the existing signatures for firmware 1.05 and prior are still there.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@codyhackw
Copy link
Contributor

Hey @TheJulianJES, what's the right way to handle this? If I'm reading the log correctly, this is failing the tests because that 0x0025 (Keepalive) cluster isn't in the ZCL clusters.

@TheJulianJES
Copy link
Collaborator

TheJulianJES commented Feb 26, 2024

Yes, the "KeepAlive" cluster will be added to zigpy. It was added with ZCL R8.
zigpy PR for adding the cluster and dep bump:

@TheJulianJES TheJulianJES changed the title Inovelli add signature for VZM35-SN fw 1.07 Add Inovelli VZM35-SN fw 1.07 support Feb 26, 2024
@TheJulianJES TheJulianJES mentioned this pull request Feb 26, 2024
3 tasks
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.87%. Comparing base (b06ad13) to head (e3bf8a8).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3003   +/-   ##
=======================================
  Coverage   87.86%   87.87%           
=======================================
  Files         301      301           
  Lines        9222     9226    +4     
=======================================
+ Hits         8103     8107    +4     
  Misses       1119     1119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES
Copy link
Collaborator

These quirks can be simplified with quirks v2 in a future PR:

For now, this is fine.

@TheJulianJES TheJulianJES merged commit 2a41331 into zigpy:dev Mar 18, 2024
6 checks passed
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants