-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tuya cover TS0601 _TZE200_9vpe3fl1
variant
#3021
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3021 +/- ##
=======================================
Coverage 87.85% 87.85%
=======================================
Files 301 301
Lines 9217 9217
=======================================
Hits 8098 8098
Misses 1119 1119 ☔ View full report in Codecov by Sentry. |
I'm trying to test this locally btw |
8bbb7b3
to
d5e9117
Compare
Look, I'm not sure if this is related to the zigbee pairing, but the motor runs on its own sometimes, but this also happened before I even started working with zha quirks, maybe it's deffective. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really need to add the device in both quirks?
(TuyaZemismartSmartCover0601
and TuyaZemismartSmartCover0601_3
)
@javicalle (I'm new to this btw) I own another zemismart motor whose model ID is also featured in those two quirks, so I thought I'd follow the pattern. Does that seem wrong? Btw, when I run this locally the motor choses |
IMHO it would be better just to add it to the needed quirk. Thanks for your contribution. |
@javicalle I removed the RF remote pairing and it's not misbehaving anymore, must've been interference. The quirk has been working flawlessly ever since. This can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed change
Adds support for Zemismart Roller Shade Motor
_TZE200_9vpe3fl1
variant.Additional information
Checklist
pre-commit
checks pass / the code has been formatted using Black