Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper to create devices from v2 quirks #3032

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

dmulcahey
Copy link
Collaborator

Proposed change

This PR adds a helper for creating devices from v2 quirks. It will not create a complete copy of the device as we no longer have a signature (we don't have the info at all any more). I think what it creates gives us what we need to test what the quirk is actually meant to do. Definitely open to suggestions...

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.85%. Comparing base (f9170ee) to head (4e21c36).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3032   +/-   ##
=======================================
  Coverage   87.85%   87.85%           
=======================================
  Files         301      301           
  Lines        9217     9217           
=======================================
  Hits         8098     8098           
  Misses       1119     1119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmulcahey
Copy link
Collaborator Author

I am going to merge this for now to unblock another PR. We can address whatever concerns we have with this approach in a followup

@dmulcahey dmulcahey merged commit c76f0e9 into dev Mar 11, 2024
14 checks passed
@dmulcahey dmulcahey deleted the dm/v2-quirk-device-helper branch March 11, 2024 18:04
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
* Add test helper to create quirks v2 quirked devices

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant