Convert Sonoff buttons to v2 quirk #3050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3050 +/- ##
==========================================
- Coverage 87.87% 87.85% -0.02%
==========================================
Files 301 300 -1
Lines 9226 9212 -14
==========================================
- Hits 8107 8093 -14
Misses 1119 1119 ☔ View full report in Codecov by Sentry. |
|
Why not convert these to v2 and forget the sig stuff? |
|
Right, perfect candidate for that. I'll convert this tomorrow. |
TheJulianJES
changed the title
SNZB-01P variantSNZB-01P to v2 quirk
TheJulianJES
changed the title
SNZB-01P to v2 quirk
TheJulianJES
commented
Mar 19, 2024
|
Codecov/project coverage decrease is expected, as a lot of code is removed. |
lgraf
pushed a commit
to lgraf/zha-device-handlers
that referenced
this pull request
May 6, 2024
* Add Sonoff button `SNZB-01P` variant * Inherit `SonoffSmartButtonSNZB01P` to use existing device triggers * Initial v2 quirk conversion for Sonoff button * Remove signature test for Sonoff button * Also convert other Sonoff button to v2 * Merge Sonoff button quirks into one file * Combine both v2 quirks into one, use less strict device triggers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This converts both existing Sonoff button quirks to a combined v2 quirk. This way we can avoid adding other signature variations.
The "signature match test" is also removed, as it doesn't make much sense with a v2 quirk(?)
Additional information
Also addresses home-assistant/core#104548 (comment)
Checklist
pre-commitchecks pass / the code has been formatted using Black