Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya soil sensor variant _TZE200_9cqcpkgb #3079

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Add Tuya soil sensor variant _TZE200_9cqcpkgb #3079

merged 1 commit into from
Apr 7, 2024

Conversation

cooki371
Copy link
Contributor

@cooki371 cooki371 commented Mar 29, 2024

Proposed change

Adding the soil sensor variant _TZE200_9cqcpkgb.
Amazon Link

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.90%. Comparing base (9ccb69a) to head (65323a9).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3079   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files         300      300           
  Lines        9222     9222           
=======================================
  Hits         8107     8107           
  Misses       1115     1115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@javicalle javicalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javicalle
Copy link
Collaborator

Adding a link to the device vendor or similar would help others to identify the device.

@javicalle javicalle added the Tuya Request/PR regarding a Tuya device label Mar 30, 2024
@cooki371
Copy link
Contributor Author

Added an amazon link to the device I tested it with.

@TheJulianJES TheJulianJES changed the title Add soil sensor _TZE200_9cqcpkgb Add Tuya soil sensor variant _TZE200_9cqcpkgb Apr 7, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES merged commit 54e44b3 into zigpy:dev Apr 7, 2024
6 checks passed
@cooki371 cooki371 deleted the patch-1 branch April 7, 2024 21:39
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
xbezdick pushed a commit to xbezdick/zha-device-handlers that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants