Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya smoke sensor variant _TZE200_rccxox8p #3090

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

Megamannen
Copy link
Contributor

@Megamannen Megamannen commented Apr 6, 2024

Proposed change

Added support for Tuya Smoke Detector TS0601 _TZE200_rccxox8p model

Additional information

A freshly ordered smoke detector came with a new model name _TZE200_rccxox8p, previously the same kind devices was with model name _TZE200_m9skfctm.

( https://a.aliexpress.com/_EQZYANb )

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.90%. Comparing base (9ccb69a) to head (6041203).

❗ Current head 6041203 differs from pull request most recent head 819f6c2. Consider uploading reports for the commit 819f6c2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3090   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files         300      300           
  Lines        9222     9222           
=======================================
  Hits         8107     8107           
  Misses       1115     1115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@javicalle javicalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But, do you mind to order it alphabetically putting the new one before _TZE200_vzekyi4c? (the last one is a TZE204)

Thanks in advance.

@TheJulianJES TheJulianJES changed the title feat: added support for TS0601_smoke with model _TZE200_rccxox8p Add Tuya smoke sensor variant _TZE200_rccxox8p Apr 7, 2024
@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Apr 7, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES merged commit df117a7 into zigpy:dev Apr 7, 2024
4 checks passed
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants